Skip to content

allow to use ChainSpec::from_genesis to unblock CI #1513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2024
Merged

allow to use ChainSpec::from_genesis to unblock CI #1513

merged 1 commit into from
Jan 15, 2024

Conversation

nanometerzhu
Copy link
Contributor

No description provided.

@nanometerzhu nanometerzhu merged commit 5627094 into master Jan 15, 2024
@nanometerzhu nanometerzhu deleted the unblock_checkin branch January 15, 2024 21:30
@kvinwang
Copy link
Collaborator

We intentionally did not add #[allow(deprecated)] in #1494 to remind us to migrate to the new API. Is there any trouble in migrating to the new API?

@nanometerzhu
Copy link
Contributor Author

We intentionally did not add #[allow(deprecated)] in #1494 to remind us to migrate to the new API. Is there any trouble in migrating to the new API?

Yes. I just created a draft PR #1515. It needs take more time to fix the test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@h4x3rotab h4x3rotab Awaiting requested review from h4x3rotab

@kvinwang kvinwang Awaiting requested review from kvinwang

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nanometerzhu @kvinwang